weirdcat/easywish
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore: todo comments;

Browse Source 
fix: txless creation of confirmation code in passwordresetbegin
This commit is contained in:
Николай
2025-07-13 02:18:46 +03:00
parent a2dd8993a6
commit a3bebd89be
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
backend/internal/services/auth.go
View File

@@ -68,6 +68,8 @@ func (a *authServiceImpl) RegistrationBegin(request models.RegistrationBeginRequ
helper, db, _ := database.NewDbHelperTransaction(a.dbctx) helper, db, _ := database.NewDbHelperTransaction(a.dbctx)
defer helper.Rollback() defer helper.Rollback()
// TODO: check occupation with redis
if occupationStatus, err = db.TXQueries.CheckUserRegistrationAvailability(db.CTX, database.CheckUserRegistrationAvailabilityParams{ if occupationStatus, err = db.TXQueries.CheckUserRegistrationAvailability(db.CTX, database.CheckUserRegistrationAvailabilityParams{
Email: request.Email, Email: request.Email,
Username: request.Username, Username: request.Username,
@@ -89,6 +91,7 @@ func (a *authServiceImpl) RegistrationBegin(request models.RegistrationBeginRequ
} else if occupationStatus.EmailBusy { } else if occupationStatus.EmailBusy {
// Falsely confirm in order to avoid disclosing registered email addresses // Falsely confirm in order to avoid disclosing registered email addresses
// TODO: save this email into redis
a.log.Warn( a.log.Warn(
"Attempted registration for a taken email", "Attempted registration for a taken email",
zap.String("email", request.Email), zap.String("email", request.Email),
@@ -176,7 +179,7 @@ func (a *authServiceImpl) RegistrationBegin(request models.RegistrationBeginRequ
} else { } else {
a.log.Debug( a.log.Debug(
"Declated registration code for a new user. Enable SMTP in the config to disable this message", "Declared registration code for a new user. Enable SMTP in the config to disable this message",
zap.String("username", user.Username), zap.String("username", user.Username),
zap.String("code", generatedCode)) zap.String("code", generatedCode))
} }
@@ -474,7 +477,7 @@ func (a *authServiceImpl) PasswordResetBegin(request models.PasswordResetBeginRe
return false, errs.ErrServerError return false, errs.ErrServerError
} }
if _, err = db.TXlessQueries.CreateConfirmationCode(db.CTX, database.CreateConfirmationCodeParams{ if _, err = db.TXQueries.CreateConfirmationCode(db.CTX, database.CreateConfirmationCodeParams{
UserID: user.ID, UserID: user.ID,
CodeType: int32(enums.PasswordResetCodeType), CodeType: int32(enums.PasswordResetCodeType),
CodeHash: hashedCode, CodeHash: hashedCode,